Various fixes to the lexer generation#8
Merged
ftomassetti merged 1 commit intoftomassetti:masterfrom Oct 14, 2022
Merged
Conversation
…in non-default lexical state (by using type command), handle matching token only defined in non-default lexical states, escape single quotes within literals and ] and - within character sets, automatically generate rule names for unnamed more/skip tokens, correct commands mapping for more/special/token to default to mode(..) commands for changes in lexical state, add feature to allow user to specify which token actions should result in pushMode/popMode commands (don't infer popMode from switch to default state), only generate fragments in one state (rules across all modes reference them without rewriting token references), support skip tokens natively and remove hack for java.jj that inferred based on token name containing "comment", properly surround "choice" token body with single set of parentheses. In master, there were hundreds of guava files that could not be successfully parsed in the JavaConversion test. These files have been marked quarantined and will not fail the test suite. I have verified that my changes do not regress parsing any of these files.
ftomassetti
approved these changes
Oct 14, 2022
Owner
ftomassetti
left a comment
There was a problem hiding this comment.
Thank you for your PR. I am happy to accept it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lexer fixes:
In master, there were hundreds of guava files that could not be successfully parsed in the JavaConversion test. These files have been marked quarantined and will not fail the test suite. I have verified that my changes do not regress parsing any of these files.